API-553 Compact serialization and Generic Records #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
added
Type: Enhancement
Priority: High
Estimation: XL
wip
yuce
reviewed
Apr 11, 2022
yuce
reviewed
Apr 12, 2022
yuce
reviewed
Apr 15, 2022
zpqrtbnk
reviewed
Apr 20, 2022
| this.putIfAbsent(schema); | ||
| this.logger.trace('SchemaService', `Found schema id ${schemaId} on the cluster`); | ||
| } else { | ||
| this.logger.trace('SchemaService', `Did not find schema id ${schemaId} on the cluster`); |
There was a problem hiding this comment.
.NET also throws an exception in this situation
test/integration/backward_compatible/parallel/serialization/compact/LazyDeserialization.js
Show resolved
Hide resolved
yuce
reviewed
Apr 20, 2022
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compact Serialization
This PR adds the compact serialization support to Node.js client. This new method is more efficient and easier to use. For Java it even works with zero config. In Node.js it is not possible and needs a portable-like configuration.
Benchmark of Eager deserialization + Controlled Serialization vs Master
The async toData/toObject issue is solved using eager deserialization when reading and controlled serialization when writing. I did a benchmark as requested by the team.
Environment
Client and Server commits
Client master: e695651
Client eager deserialization: 9cf2299
Server commit: hazelcast/hazelcast@151c683
Lab environment
1 client 1 server on lab 116 117
command on 116:
node Benchmark.js -t 15000000 -c 1024command on 117:
docker run --rm --net=host -p 10.212.1.117:5701:5701 hazelcast/hazelcast:5.1-SNAPSHOTResults
Master
Starting warm-up with 1500000 operations
Warm-up finished
Took 237.587670114 seconds for 15000000 operations
Ops/s: 63134.589403577455
Benchmark finished
Eager deserialization
Starting warm-up with 1500000 operations
Warm-up finished
Took 240.487756286 seconds for 15000000 operations
Ops/s: 62373.237755028385
Benchmark finished
Another run to see deviation of the result:
Starting warm-up with 1500000 operations
Warm-up finished
Took 233.191881556 seconds for 15000000 operations
Ops/s: 64324.70933340712
Benchmark finished
So the deviation is high and about 1-2k. The %1 difference is normal and I conclude that performance did not change. Runs on local also is the same.
END RESULT
There is no difference.