Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1274

Merged
merged 16 commits into from
Apr 14, 2022
Merged

Update dependencies #1274

merged 16 commits into from
Apr 14, 2022

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Apr 13, 2022

Somehow, tests with fake timers failed due to wrong usage. I fixed them as well. The link to the fail. The fail happens on current master as well. Don't know what caused them to fail now.

@srknzl srknzl added the dependencies Pull requests that update a dependency file label Apr 13, 2022
@srknzl srknzl added this to the 5.1.0 milestone Apr 13, 2022
@srknzl srknzl requested review from yuce and zpqrtbnk April 13, 2022 19:51
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1274 (b02003f) into master (52bba69) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   92.64%   92.20%   -0.44%     
==========================================
  Files         440      440              
  Lines       14553    14553              
  Branches     1095     1095              
==========================================
- Hits        13483    13419      -64     
- Misses        787      845      +58     
- Partials      283      289       +6     
Impacted Files Coverage Δ
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) ⬇️
src/network/ConnectionManager.ts 75.35% <0.00%> (-9.63%) ⬇️
src/invocation/InvocationService.ts 94.24% <0.00%> (-1.33%) ⬇️
src/util/Util.ts 87.26% <0.00%> (-1.28%) ⬇️
src/config/ConfigBuilder.ts 90.26% <0.00%> (-1.06%) ⬇️
src/invocation/ClusterService.ts 94.01% <0.00%> (-0.86%) ⬇️
src/core/HazelcastError.ts 75.20% <0.00%> (-0.80%) ⬇️
src/protocol/ErrorFactory.ts 63.90% <0.00%> (-0.76%) ⬇️
src/nearcache/NearCache.ts 92.24% <0.00%> (+1.55%) ⬆️
src/proxy/NearCachedMapProxy.ts 98.27% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bba69...b02003f. Read the comment docs.

@srknzl
Copy link
Member Author

srknzl commented Apr 13, 2022

@zpqrtbnk @yuce Can you give priority to this one because the fail I am fixing in this PR happens in other PRs as well.

Copy link

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@srknzl srknzl merged commit 5a07045 into hazelcast:master Apr 14, 2022
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
* Fix tests with fake timers failures due to wrong usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants