Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak in ReliableTopicListenerRunner.next API-1514 #1379

Merged

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Sep 30, 2022

Clean cherry-picked backport of #1377

I will merge this PR with one approval.

@srknzl srknzl added this to the 5.1.1 milestone Sep 30, 2022
@srknzl srknzl requested review from utku-caglayan and mdumandag and removed request for utku-caglayan September 30, 2022 21:04
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1379 (917b53c) into 5.1.x (baa1fa9) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            5.1.x    #1379      +/-   ##
==========================================
- Coverage   92.12%   91.74%   -0.38%     
==========================================
  Files         463      463              
  Lines       16347    16347              
  Branches     1329     1329              
==========================================
- Hits        15060    14998      -62     
- Misses        897      954      +57     
- Partials      390      395       +5     
Impacted Files Coverage Δ
src/proxy/EntryListener.ts 100.00% <ø> (ø)
src/proxy/topic/ReliableTopicListenerRunner.ts 82.22% <100.00%> (ø)
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) ⬇️
src/network/ConnectionManager.ts 75.35% <0.00%> (-8.46%) ⬇️
src/invocation/InvocationService.ts 93.33% <0.00%> (-1.97%) ⬇️
src/core/HazelcastError.ts 76.51% <0.00%> (-1.52%) ⬇️
src/protocol/ErrorFactory.ts 63.90% <0.00%> (-1.51%) ⬇️
src/config/ConfigBuilder.ts 89.67% <0.00%> (-1.01%) ⬇️
src/invocation/ClusterService.ts 94.01% <0.00%> (-0.86%) ⬇️
src/util/Util.ts 87.89% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srknzl
Copy link
Member Author

srknzl commented Sep 30, 2022

The coverage differences must be due to not running EE tests on maintenance branch PRs.

@srknzl srknzl merged commit 71f6574 into hazelcast:5.1.x Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants