Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak in ReliableTopicListenerRunner.next API-1514 #1380

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Sep 30, 2022

Clean cherry-picked backport of #1377

I will merge this PR with one approval.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #1380 (fe43afa) into 5.0.x (6612a0f) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            5.0.x    #1380      +/-   ##
==========================================
- Coverage   92.64%   92.18%   -0.46%     
==========================================
  Files         438      438              
  Lines       16857    16857              
  Branches     1080     1080              
==========================================
- Hits        15617    15540      -77     
- Misses        959     1030      +71     
- Partials      281      287       +6     
Impacted Files Coverage Δ
src/proxy/topic/ReliableTopicListenerRunner.ts 84.31% <100.00%> (ø)
src/codec/ClientAuthenticationCustomCodec.ts 40.42% <0.00%> (-34.05%) ⬇️
src/network/ConnectionManager.ts 77.17% <0.00%> (-9.50%) ⬇️
src/config/ConfigBuilder.ts 93.82% <0.00%> (-2.78%) ⬇️
src/core/HazelcastError.ts 65.55% <0.00%> (-1.12%) ⬇️
src/invocation/InvocationService.ts 93.63% <0.00%> (-0.75%) ⬇️
src/protocol/ErrorFactory.ts 64.96% <0.00%> (-0.73%) ⬇️
src/invocation/ClusterService.ts 92.19% <0.00%> (-0.71%) ⬇️
src/util/Util.ts 88.05% <0.00%> (-0.63%) ⬇️
src/core/DateTimeClasses.ts 90.50% <0.00%> (+1.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srknzl srknzl merged commit 421933b into hazelcast:5.0.x Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants