Make ReadResultSet iterable [API-1315] #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
- Coverage 93.30% 93.28% -0.02%
==========================================
Files 464 464
Lines 16377 16384 +7
Branches 1331 1332 +1
==========================================
+ Hits 15280 15284 +4
- Misses 799 801 +2
- Partials 298 299 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srknzl
reviewed
Oct 13, 2022
src/core/ReadResultSet.ts
Outdated
Comment on lines
64
to
69
| /** | ||
| * Returns an iterator for elements in the list. | ||
| * | ||
| * @returns the iterator for elements in the list. | ||
| */ | ||
| values(): Iterator<T>; |
There was a problem hiding this comment.
You are right. We can remove it.
srknzl
reviewed
Oct 13, 2022
| @@ -42,4 +42,14 @@ describe('LazyReadResultSetTest', function () { | |||
| const set = new LazyReadResultSet(mockSerializationService, 4, [1, 2, 3, 4], [11, 12, 13, 14], 15); | |||
| expect(set.get(4)).to.be.undefined; | |||
| }); | |||
|
|
|||
| it('object can be iteratable', function () { | |||
There was a problem hiding this comment.
Suggested change
| it('object can be iteratable', function () { | |
| it('should be iterable', function () { |
"it should be iterable" is fine I think.
There was a problem hiding this comment.
I agree you. I will correct it.
srknzl
approved these changes
Oct 14, 2022
harunalpak
added a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* Make ReadResultSet iterable [API-1315] * Changes made according to comments on PR.[API-1315]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes done: