-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jaas code samples #466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
requested review from
Serdaro and
mustafaiman
and removed request for
Serdaro
March 4, 2019 07:05
Serdaro
suggested changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed.
Serdaro
approved these changes
Mar 4, 2019
mustafaiman
reviewed
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, comprehensive sample and documentation 👏 I have only a few minor comments.
code_samples/jaas_sample/hazelcast-member/src/main/resources/hazelcast.xml
Outdated
Show resolved
Hide resolved
mustafaiman
approved these changes
Mar 4, 2019
dbrimley
suggested changes
Mar 5, 2019
verify |
mdumandag
force-pushed
the
jaasCodeSample
branch
from
March 5, 2019 13:34
9c2a9e4
to
9679a5f
Compare
mdumandag
force-pushed
the
jaasCodeSample
branch
from
March 5, 2019 13:35
9679a5f
to
10baefd
Compare
verify |
dbrimley
approved these changes
Mar 5, 2019
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* add jaas code samples * fix typos * fixes for the reviews * add a note about starting bootstrap.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds JAAS code samples and README documentation for the Node.js client.
I used
UsernamePasswordCredentials
on thecom.hazelcast.security
package on the code that I put to README to not have too many Java code on the READMEOn the code samples, I put an example where I implemented the interface from scratch to show how to do it.