Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jaas code samples #466

Merged
merged 4 commits into from
Mar 5, 2019
Merged

Conversation

mdumandag
Copy link
Contributor

This pr adds JAAS code samples and README documentation for the Node.js client.

I used UsernamePasswordCredentials on the com.hazelcast.security package on the code that I put to README to not have too many Java code on the README

On the code samples, I put an example where I implemented the interface from scratch to show how to do it.

Copy link
Contributor

@Serdaro Serdaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
code_samples/jaas_sample/README.md Outdated Show resolved Hide resolved
code_samples/jaas_sample/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mustafaiman mustafaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, comprehensive sample and documentation 👏 I have only a few minor comments.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
code_samples/jaas_sample/README.md Outdated Show resolved Hide resolved
code_samples/jaas_sample/README.md Show resolved Hide resolved
code_samples/jaas_sample/client.js Outdated Show resolved Hide resolved
code_samples/jaas_sample/README.md Outdated Show resolved Hide resolved
@mdumandag
Copy link
Contributor Author

verify

@mdumandag
Copy link
Contributor Author

verify

@mdumandag mdumandag merged commit 662031e into hazelcast:master Mar 5, 2019
@mdumandag mdumandag deleted the jaasCodeSample branch March 5, 2019 16:00
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
* add jaas code samples

* fix typos

* fixes for the reviews

* add a note about starting bootstrap.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants