api-21 Reduce number of allocated Buffers for writes #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
force-pushed
the
v4.0/experiment/improve-buffer-handling-in-client-message
branch
from
0338310
to
af8b3ca
Compare
puzpuzpuz
changed the title
mdumandag
approved these changes
Sep 22, 2020
|
@mdumandag thanks for the review! |
puzpuzpuz
deleted the
v4.0/experiment/improve-buffer-handling-in-client-message
branch
srknzl
changed the title
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #559
Gets rid of almost all unnecessary
Bufferallocations done in the client message write process. The performance impact of this change is around 8-10% inmap.set(42, 42)benchmark.