Support new metrics binary format for client stats #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
changed the title
puzpuzpuz
force-pushed
the
v4.1/enhancement/new-metrics-binary-format
branch
3 times, most recently
from
c54f023
to
c6eeb94
Compare
For backward-compatibility purposes, metrics are written into both client attributes and new metrics binary.
puzpuzpuz
force-pushed
the
v4.1/enhancement/new-metrics-binary-format
branch
from
c6eeb94
to
84e8641
Compare
puzpuzpuz
force-pushed
the
v4.1/enhancement/new-metrics-binary-format
branch
from
709ca13
to
e6fb1ab
Compare
mdumandag
reviewed
Jan 20, 2021
|
@mdumandag could you take another look at the PR? All comments seem to be addressed. |
mdumandag
approved these changes
Jan 20, 2021
|
@mdumandag thanks for the review! |
|
@mdumandag I've pushed the workaround fix discussed in https://github.com/hazelcast/management-center/issues/4165 to include it into this PR. Please check e1786f3 |
|
Looks good to me |
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
For backward-compatibility purposes, metrics are written into both client attributes and new metrics binary. Also includes the following: * Fix client type value in statistics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556
For backward-compatibility purposes, metrics are written into both client attributes and new metrics binary.
Binary generator core PR: hazelcast/hazelcast#18066
Related MC issues: