API-657 GH actions #978
Merged
API-657 GH actions #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verify |
mdumandag
reviewed
Aug 4, 2021
mdumandag
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Looks good overall. I left some naming-related comments.
BTW, we should work on shortening the test duration as it is close to 30 min mark now. It is almost as long as the IMDG itself. We can maybe make use of parallel test runs or work on the long tests to make them simpler/shorter
|
I checked mocha parallel test feature but I remember it was hard to enable because running tests in parallel affect other tests. I will try to do again. Opening a issue. #1008 |
|
After this is merged, should we ditch Jenkins @mdumandag ? |
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a pr builder and branch builder. we need to add HAZELCAST_ENTERPRISE_KEY secret to the repo