[CN-1259] Fix Failed to watch *v1.Node: unknown (get nodes) #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagric0
added
the
fix
cagric0
requested review from
SeriyBg and
semihbkgr
and removed request for
a team
semihbkgr
approved these changes
Apr 25, 2024
| @@ -126,6 +126,7 @@ Rules needed for giving Hazelcast node read permissions | |||
| verbs: | |||
| - get | |||
| - list | |||
| - watch | |||
There was a problem hiding this comment.
Do you know why it was removed previously, or was it never added?
There was a problem hiding this comment.
I don't know actually let me check. And also I couldn't find why the operator is watching nodes but this additional permission fixes the issue.
There was a problem hiding this comment.
get was there for a long time more than 1 year but list is added with this PR #966. I think this watch error started with the same PR.
I found this issue in the controller-runtime repo:
kubernetes-sigs/controller-runtime#1156
It seems get or list requires watch permission unless you have a non-caching client.
SeriyBg
approved these changes
Apr 26, 2024
hasancelik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the error seen in the operator log:
E0425 15:01:06.189842 34 reflector.go:147] pkg/mod/k8s.io/client-go@v0.28.3/tools/cache/reflector.go:229: Failed to watch *v1.Node: unknown (get nodes)