Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-395] Make resources and scheduling spec fields updatable for HZ and MC #227

Merged
merged 2 commits into from May 31, 2022

Conversation

mtyazici
Copy link
Contributor

With the current changes, persistence is the only field that updates are not reflected in the operator.

@mtyazici mtyazici requested review from a team, hakanmemisoglu and SeriyBg and removed request for a team May 30, 2022 08:10
Copy link
Contributor

@SeriyBg SeriyBg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, it would be great if we can have some tests for it (probably integration)

Copy link
Contributor

@hakanmemisoglu hakanmemisoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1 for integration test

@mtyazici
Copy link
Contributor Author

Sure, I will add integration tests for these.

@mtyazici mtyazici merged commit 8c819ef into main May 31, 2022
@mtyazici mtyazici deleted the cn-395 branch May 31, 2022 13:22
@mtyazici mtyazici added this to the 5.3 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants