Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-438] Use Agent asynchronous upload API #288

Merged
merged 1 commit into from Jul 21, 2022
Merged

[CN-438] Use Agent asynchronous upload API #288

merged 1 commit into from Jul 21, 2022

Conversation

dzeromski-hazelcast
Copy link
Contributor

No description provided.

@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-438-use-agent-asynchronous-upload-api branch from bc8411b to 77625d2 Compare July 14, 2022 10:46
SeriyBg
SeriyBg reviewed Jul 14, 2022
View reviewed changes
test/e2e/hazelcast_persistence_test.go Outdated Show resolved Hide resolved
test/e2e/config/hazelcast/config.go Outdated Show resolved Hide resolved
internal/upload/upload.go Outdated Show resolved Hide resolved
cagric0
cagric0 reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@cagric0 cagric0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement and also thanks for the new and more generic rest client. I have some questions and feedbacks. After them it seems finished.

config/samples/_v1alpha1_hazelcast_persistence_agent.yaml Outdated Show resolved Hide resolved
internal/rest/upload_service.go Show resolved Hide resolved
internal/rest/client.go Show resolved Hide resolved
controllers/hazelcast/hot_backup_controller.go Outdated Show resolved Hide resolved
controllers/hazelcast/hot_backup_controller.go Outdated Show resolved Hide resolved
controllers/hazelcast/hot_backup_controller.go Show resolved Hide resolved
controllers/hazelcast/hot_backup_controller.go Show resolved Hide resolved
controllers/hazelcast/hot_backup_controller.go Outdated Show resolved Hide resolved
@hasancelik hasancelik removed their request for review July 20, 2022 05:43
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-438-use-agent-asynchronous-upload-api branch 3 times, most recently from b330954 to 3a45ff5 Compare July 20, 2022 08:15
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-438-use-agent-asynchronous-upload-api branch 4 times, most recently from 8c57e38 to 1093a5b Compare July 21, 2022 12:38
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-438-use-agent-asynchronous-upload-api branch 2 times, most recently from 6ea2eb3 to ab15efb Compare July 21, 2022 15:13
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-438-use-agent-asynchronous-upload-api branch from ab15efb to 9d15e44 Compare July 21, 2022 18:28
@dzeromski-hazelcast dzeromski-hazelcast merged commit 6dc7ed7 into main Jul 21, 2022
@dzeromski-hazelcast dzeromski-hazelcast deleted the CN-438-use-agent-asynchronous-upload-api branch July 21, 2022 20:10
@angelasimms angelasimms mentioned this pull request Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeriyBg SeriyBg SeriyBg approved these changes

@cagric0 cagric0 cagric0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dzeromski-hazelcast @SeriyBg @cagric0