Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-475] Add finalizer logic for deleting dependent child CRs #314

Merged
merged 7 commits into from Aug 17, 2022
Merged

[CN-475] Add finalizer logic for deleting dependent child CRs #314

merged 7 commits into from Aug 17, 2022

Conversation

mtyazici
Copy link
Contributor

@mtyazici mtyazici commented Aug 8, 2022

Changes done to both

  • Hazelcast CR: before deletion it deletes dependent Map and HotBackup CRs.
  • Map CR: before deletion it deletes dependent WanReplication CRs.

@mtyazici mtyazici requested review from a team, hasancelik and dzeromski-hazelcast and removed request for a team August 9, 2022 08:35
@mtyazici mtyazici requested a review from a team as a code owner August 10, 2022 13:26
@mtyazici mtyazici merged commit 0dc2d34 into main Aug 17, 2022
@mtyazici mtyazici deleted the cn-475 branch August 17, 2022 11:50
cagric0 added a commit that referenced this pull request Aug 22, 2022
@cagric0
Revert "[CN-475] Add finalizer logic for deleting dependent child CRs (…
6273653 
…#314)"

This reverts commit 0dc2d34.
@angelasimms angelasimms mentioned this pull request Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzeromski-hazelcast dzeromski-hazelcast dzeromski-hazelcast approved these changes

@hasancelik hasancelik hasancelik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtyazici @hasancelik @dzeromski-hazelcast