Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-639] Fix Hazelcast ConfigMap when multiple CRs for Data Structures are created #501

Merged
merged 30 commits into from Dec 19, 2022

Conversation

SeriyBg
Copy link
Contributor

@SeriyBg SeriyBg commented Dec 13, 2022

Description

When multiple Data Structures CR was created, only the last one was stored in the hazelcast.yaml ConfigMap

User Impact

User can create multiple CR and all will be stored in the ConfigMap

@SeriyBg SeriyBg requested a review from a team as a code owner December 13, 2022 11:54
@SeriyBg SeriyBg requested review from kutluhanmetin and mtyazici and removed request for a team December 13, 2022 11:54
@github-actions github-actions bot added the fix This type is used to identify changes related to backward-compatible bug fixes label Dec 13, 2022
@mtyazici mtyazici added this to the 5.6 milestone Dec 14, 2022
Copy link
Contributor

@kutluhanmetin kutluhanmetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SeriyBg SeriyBg merged commit 2430110 into main Dec 19, 2022
@SeriyBg SeriyBg deleted the list-cr-fix branch December 19, 2022 09:07
semihbkgr pushed a commit that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This type is used to identify changes related to backward-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants