Improve map deletion from Wan status #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtyazici
requested review from
SeriyBg and
cagric0
and removed request for
a team
cagric0
reviewed
Feb 16, 2023
Comment on lines
+207
to
+215
| for mapWanKey := range wan.Status.WanReplicationMapsStatus { | ||
| m, ok := publishedMaps[mapWanKey] | ||
| if !ok { | ||
| // Delete map without publisherID from status | ||
| if err := deleteWanMapStatus(ctx, r.Client, wan, mapWanKey); err != nil { | ||
| return err | ||
| } | ||
| continue | ||
| } |
There was a problem hiding this comment.
Since you remove the map with empty publisherId from the status in the stopWanReplicationMap, I think we don't need to change here and an additional check for publisherId
There was a problem hiding this comment.
Yes, but how are we going to generate a client for that map? Client is a parameter for stopWanReplicationMap function. Map and Hazelcast CR might have been deleted already.
cagric0
approved these changes
Feb 16, 2023
SeriyBg
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved map deletion from Wan status when publisher ID was empty. Also improved logs for easier debugging.
User Impact