New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CN-807] Remove separate secret for mTLS #696
Merged
dzeromski-hazelcast
merged 2 commits into
main
from
CN-807-remove-separate-secret-for-mtls
Apr 18, 2023
Merged
[CN-807] Remove separate secret for mTLS #696
dzeromski-hazelcast
merged 2 commits into
main
from
CN-807-remove-separate-secret-for-mtls
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzeromski-hazelcast
force-pushed
the
CN-807-remove-separate-secret-for-mtls
branch
from
April 6, 2023 15:23
16c90a3
to
f4ef196
Compare
dzeromski-hazelcast
requested review from
hasancelik and
cagric0
and removed request for
a team
April 6, 2023 15:26
dzeromski-hazelcast
force-pushed
the
CN-807-remove-separate-secret-for-mtls
branch
from
April 6, 2023 16:01
f4ef196
to
bbbb003
Compare
dzeromski-hazelcast
temporarily deployed
to
report
April 6, 2023 17:30
— with
GitHub Actions
Inactive
hasancelik
reviewed
Apr 14, 2023
cagric0
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. When you address Hasan's comments, I am okay.
dzeromski-hazelcast
force-pushed
the
CN-807-remove-separate-secret-for-mtls
branch
from
April 18, 2023 10:03
3d0665c
to
ea0713b
Compare
dzeromski-hazelcast
force-pushed
the
CN-807-remove-separate-secret-for-mtls
branch
from
April 18, 2023 16:08
ea0713b
to
5661a00
Compare
dzeromski-hazelcast
temporarily deployed
to
report
April 18, 2023 16:55
— with
GitHub Actions
Inactive
dzeromski-hazelcast
force-pushed
the
CN-807-remove-separate-secret-for-mtls
branch
from
April 18, 2023 18:13
5661a00
to
42c90b3
Compare
dzeromski-hazelcast
temporarily deployed
to
report
April 18, 2023 18:33
— with
GitHub Actions
Inactive
dzeromski-hazelcast
force-pushed
the
CN-807-remove-separate-secret-for-mtls
branch
from
April 18, 2023 19:10
42c90b3
to
bef64bd
Compare
dzeromski-hazelcast
temporarily deployed
to
report
April 18, 2023 19:31
— with
GitHub Actions
Inactive
dzeromski-hazelcast
added a commit
that referenced
this pull request
Apr 19, 2023
This reverts commit a05a761.
dzeromski-hazelcast
added a commit
that referenced
this pull request
Apr 24, 2023
This reverts commit cdfa742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently moved
hazelcast.yaml
file from configmap to secret and now we can use single secret to store all files required for operator and members to work.