Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-807] Remove separate secret for mTLS #696

Merged
merged 2 commits into from Apr 18, 2023

Conversation

dzeromski-hazelcast
Copy link
Contributor

Description

We recently moved hazelcast.yaml file from configmap to secret and now we can use single secret to store all files required for operator and members to work.

@dzeromski-hazelcast dzeromski-hazelcast added this to the 5.8 milestone Apr 6, 2023
@dzeromski-hazelcast dzeromski-hazelcast added the enhancement New feature or request label Apr 6, 2023
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-807-remove-separate-secret-for-mtls branch from 16c90a3 to f4ef196 Compare April 6, 2023 15:23
@dzeromski-hazelcast dzeromski-hazelcast marked this pull request as ready for review April 6, 2023 15:26
@dzeromski-hazelcast dzeromski-hazelcast requested a review from a team as a code owner April 6, 2023 15:26
@dzeromski-hazelcast dzeromski-hazelcast requested review from hasancelik and cagric0 and removed request for a team April 6, 2023 15:26
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-807-remove-separate-secret-for-mtls branch from f4ef196 to bbbb003 Compare April 6, 2023 16:01
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report April 6, 2023 17:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Test Results

Total Tests 🔴 Failures 🟠 Errors ⚪ Skipped
OS 78 0 0 40
EE 78 22 0 14

.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
internal/mtls/client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cagric0 cagric0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When you address Hasan's comments, I am okay.

@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-807-remove-separate-secret-for-mtls branch from 3d0665c to ea0713b Compare April 18, 2023 10:03
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-807-remove-separate-secret-for-mtls branch from ea0713b to 5661a00 Compare April 18, 2023 16:08
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report April 18, 2023 16:55 — with GitHub Actions Inactive
@github-actions
Copy link

Test Results

Total Tests 🔴 Failures 🟠 Errors ⚪ Skipped
OS 80 0 0 40
EE 80 23 0 14

@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-807-remove-separate-secret-for-mtls branch from 5661a00 to 42c90b3 Compare April 18, 2023 18:13
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report April 18, 2023 18:33 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-807-remove-separate-secret-for-mtls branch from 42c90b3 to bef64bd Compare April 18, 2023 19:10
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report April 18, 2023 19:31 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast merged commit a05a761 into main Apr 18, 2023
18 checks passed
@dzeromski-hazelcast dzeromski-hazelcast deleted the CN-807-remove-separate-secret-for-mtls branch April 18, 2023 19:37
dzeromski-hazelcast added a commit that referenced this pull request Apr 19, 2023
@dzeromski-hazelcast dzeromski-hazelcast restored the CN-807-remove-separate-secret-for-mtls branch April 19, 2023 13:19
dzeromski-hazelcast added a commit that referenced this pull request Apr 24, 2023
@dzeromski-hazelcast dzeromski-hazelcast deleted the CN-807-remove-separate-secret-for-mtls branch August 16, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants