Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-812] Rename secret to secretName for ManagementCenter and HotBackup #740

Merged
merged 6 commits into from May 17, 2023
Merged

[CN-812] Rename secret to secretName for ManagementCenter and HotBackup #740

merged 6 commits into from May 17, 2023

Conversation

SeriyBg
Copy link
Contributor

@SeriyBg SeriyBg commented May 16, 2023

User Impact

The field licenseKeySecret in ManagementCenterSpec was renamed to licenseKeySecretName.
The field secret in HotBackupSpec was renamed to secretName.

@SeriyBg SeriyBg requested a review from semihbkgr May 16, 2023 12:26
@SeriyBg SeriyBg requested a review from a team as a code owner May 16, 2023 12:26
@SeriyBg SeriyBg requested review from hasancelik and removed request for a team May 16, 2023 12:26
semihbkgr
semihbkgr reviewed May 16, 2023
View reviewed changes
Copy link
Member

@semihbkgr semihbkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can consider to set values to new fields taking values from their corresponding deprecated fields in reconciler loop.

test/e2e/config/managementcenter/config.go Outdated Show resolved Hide resolved
test/e2e/helpers_test.go Outdated Show resolved Hide resolved
@SeriyBg @semihbkgr
Update test/e2e/helpers_test.go
2c2d36c 
Co-authored-by: Semih Buyukgungor <semih.buyukgungor@hazelcast.com>
@SeriyBg
Copy link
Contributor Author

SeriyBg commented May 16, 2023

Maybe we can consider to set values to new fields taking values from their corresponding deprecated fields in reconciler loop.

This is a good option. But for this, I think we also need to have the defaulter webhook. So I will create a JIRA ticket to implement it in a separate task.

@SeriyBg SeriyBg requested a review from semihbkgr May 16, 2023 14:36
SeriyBg and others added 3 commits May 16, 2023 17:37
@SeriyBg SeriyBg temporarily deployed to report May 16, 2023 15:11 — with GitHub Actions Inactive
@semihbkgr semihbkgr added this to the 5.8 milestone May 17, 2023
@semihbkgr semihbkgr added the enhancement New feature or request label May 17, 2023
@semihbkgr semihbkgr merged commit 28f77b0 into main May 17, 2023
42 checks passed
@semihbkgr semihbkgr deleted the CN-812-smaples-yaml branch May 17, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semihbkgr semihbkgr semihbkgr approved these changes

@hasancelik hasancelik Awaiting requested review from hasancelik hasancelik is a code owner automatically assigned from hazelcast/cloud-native

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeriyBg @semihbkgr