Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-868] Allow to use TLS only with Hazelcast Enterprise version #756

Merged

Conversation

dzeromski-hazelcast
Copy link
Contributor

Description

Allow to use TLS onky with only with Hazelcast Enterprise version. To do that we check if licenseKeySecretName was set.

Example:

apiVersion: hazelcast.com/v1alpha1
kind: Hazelcast
metadata:
  name: hazelcast
spec:
  clusterSize: 3
  tls:
    secretName: example

will fail with:

$ k apply -f tls.yaml 
The Hazelcast "hazelcast" is invalid: spec.tls: Required value: Hazelcast TLS requires enterprise version

@dzeromski-hazelcast dzeromski-hazelcast requested a review from a team as a code owner June 7, 2023 18:11
@dzeromski-hazelcast dzeromski-hazelcast requested review from hasancelik and cagric0 and removed request for a team June 7, 2023 18:11
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-867-make-tls-secretname-a-required-property branch from beb9d6e to 0977166 Compare June 7, 2023 18:11
@dzeromski-hazelcast dzeromski-hazelcast added the fix This type is used to identify changes related to backward-compatible bug fixes label Jun 7, 2023
@dzeromski-hazelcast dzeromski-hazelcast added this to the 5.8 milestone Jun 7, 2023
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-867-make-tls-secretname-a-required-property branch 3 times, most recently from 6d9e009 to f36e01f Compare June 7, 2023 19:50
Copy link
Member

@semihbkgr semihbkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM 👍. Beside this PR, we would better to add license key check for every enterprise features. The another point, we can check the presence of license key secret as well.

controllers/hazelcast/hazelcast_resources.go Outdated Show resolved Hide resolved
controllers/hazelcast/hazelcast_resources.go Outdated Show resolved Hide resolved
controllers/managementcenter/managementcenter_resources.go Outdated Show resolved Hide resolved
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-868-allow-to-use-tls-only-with-hazelcast-ent branch from 22e0925 to fba3873 Compare June 8, 2023 09:37
@dzeromski-hazelcast
Copy link
Contributor Author

It LGTM +1. Beside this PR, we would better to add license key check for every enterprise features. The another point, we can check the presence of license key secret as well.

Agree. We have already separate task to do it so we shouldn't forget about it: CN-827.

Base automatically changed from CN-867-make-tls-secretname-a-required-property to main June 8, 2023 16:28
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-868-allow-to-use-tls-only-with-hazelcast-ent branch from fba3873 to b631a8b Compare June 8, 2023 16:31
@dzeromski-hazelcast dzeromski-hazelcast merged commit 45c14c2 into main Jun 8, 2023
17 checks passed
@dzeromski-hazelcast dzeromski-hazelcast deleted the CN-868-allow-to-use-tls-only-with-hazelcast-ent branch June 8, 2023 16:38
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report June 8, 2023 16:59 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This type is used to identify changes related to backward-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants