Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-879] fail JetJob if Hazelcast cluster is not running #799

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

SeriyBg
Copy link
Contributor

@SeriyBg SeriyBg commented Jul 7, 2023

User Impact

Creating the JetJob for the Hazelcast cluster that is not Running will result in Failed state

@SeriyBg SeriyBg added this to the 5.9 milestone Jul 7, 2023
@SeriyBg SeriyBg requested a review from a team as a code owner July 7, 2023 09:46
@SeriyBg SeriyBg requested review from cagric0 and semihbkgr and removed request for a team July 7, 2023 09:46
@SeriyBg SeriyBg added the enhancement New feature or request label Jul 7, 2023
@SeriyBg SeriyBg temporarily deployed to report July 7, 2023 10:19 — with GitHub Actions Inactive
Copy link
Member

@semihbkgr semihbkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Cannot we test this case in integration tests?

@SeriyBg SeriyBg changed the title [CN-879] faild JetJob if Hazelcast cluster is not running [CN-879] fail JetJob if Hazelcast cluster is not running Jul 10, 2023
@SeriyBg
Copy link
Contributor Author

SeriyBg commented Jul 10, 2023

LGTM 👍. Cannot we test this case in integration tests?

Nope, as the JetJob won't run in the integration test

@SeriyBg SeriyBg merged commit b2f7ca1 into main Jul 11, 2023
18 checks passed
@SeriyBg SeriyBg deleted the CN-879-jj-bucket branch July 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants