New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CN-945] Add SQL configuration in Hazelcast CR #831
Merged
dzeromski-hazelcast
merged 5 commits into
main
from
CN-945-add-sql-configuration-in-hazelcast-cr
Aug 16, 2023
Merged
[CN-945] Add SQL configuration in Hazelcast CR #831
dzeromski-hazelcast
merged 5 commits into
main
from
CN-945-add-sql-configuration-in-hazelcast-cr
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzeromski-hazelcast
temporarily deployed
to
report
August 8, 2023 11:01
— with
GitHub Actions
Inactive
dzeromski-hazelcast
force-pushed
the
CN-945-add-sql-configuration-in-hazelcast-cr
branch
from
August 11, 2023 15:48
295acfb
to
036be41
Compare
dzeromski-hazelcast
temporarily deployed
to
report
August 11, 2023 16:21
— with
GitHub Actions
Inactive
dzeromski-hazelcast
requested review from
hasancelik and
semihbkgr
and removed request for
a team
August 11, 2023 16:30
dzeromski-hazelcast
temporarily deployed
to
report
August 11, 2023 16:43
— with
GitHub Actions
Inactive
semihbkgr
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
hasancelik
requested changes
Aug 14, 2023
dzeromski-hazelcast
temporarily deployed
to
report
August 14, 2023 09:54
— with
GitHub Actions
Inactive
dzeromski-hazelcast
force-pushed
the
CN-945-add-sql-configuration-in-hazelcast-cr
branch
from
August 14, 2023 10:44
6b9b681
to
b0c524e
Compare
dzeromski-hazelcast
temporarily deployed
to
report
August 14, 2023 11:16
— with
GitHub Actions
Inactive
hasancelik
approved these changes
Aug 15, 2023
dzeromski-hazelcast
temporarily deployed
to
report
August 15, 2023 18:55
— with
GitHub Actions
Inactive
dzeromski-hazelcast
deleted the
CN-945-add-sql-configuration-in-hazelcast-cr
branch
August 16, 2023 07:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SQL configuration to Hazelcast:
Example CR:
User Impact
Users can now configure
sql.catalogPersistence
and persist SQL mappings between cluster restarts.