Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-945] Add SQL configuration in Hazelcast CR #831

Merged

Conversation

dzeromski-hazelcast
Copy link
Contributor

@dzeromski-hazelcast dzeromski-hazelcast commented Aug 8, 2023

Description

Add SQL configuration to Hazelcast:

  sql:
    statement-timeout-millis: 0
    catalog-persistence-enabled: false

Example CR:

apiVersion: hazelcast.com/v1alpha1
kind: Hazelcast
metadata:
  name: hazelcast
spec:
  clusterSize: 1
  repository: 'docker.io/hazelcast/hazelcast-enterprise'
  licenseKeySecretName: hazelcast-license-key
  persistence:
    baseDir: "/data/hot-restart/"  
    clusterDataRecoveryPolicy: "FullRecoveryOnly"  
    pvc:
      accessModes: ["ReadWriteOnce"]
      requestStorage: 8Gi  
  sql:
    statementTimeout: 1000
    catalogPersistence: true

User Impact

Users can now configure sql.catalogPersistence and persist SQL mappings between cluster restarts.

@dzeromski-hazelcast dzeromski-hazelcast added the enhancement New feature or request label Aug 8, 2023
@dzeromski-hazelcast dzeromski-hazelcast added this to the 5.9 milestone Aug 8, 2023
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report August 8, 2023 11:01 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-945-add-sql-configuration-in-hazelcast-cr branch from 295acfb to 036be41 Compare August 11, 2023 15:48
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report August 11, 2023 16:21 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast marked this pull request as ready for review August 11, 2023 16:30
@dzeromski-hazelcast dzeromski-hazelcast requested a review from a team as a code owner August 11, 2023 16:30
@dzeromski-hazelcast dzeromski-hazelcast requested review from hasancelik and semihbkgr and removed request for a team August 11, 2023 16:30
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report August 11, 2023 16:43 — with GitHub Actions Inactive
Copy link
Member

@semihbkgr semihbkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

api/v1alpha1/hazelcast_types.go Outdated Show resolved Hide resolved
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report August 14, 2023 09:54 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast force-pushed the CN-945-add-sql-configuration-in-hazelcast-cr branch from 6b9b681 to b0c524e Compare August 14, 2023 10:44
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report August 14, 2023 11:16 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast temporarily deployed to report August 15, 2023 18:55 — with GitHub Actions Inactive
@dzeromski-hazelcast dzeromski-hazelcast merged commit 1d89ae1 into main Aug 16, 2023
18 checks passed
@dzeromski-hazelcast dzeromski-hazelcast deleted the CN-945-add-sql-configuration-in-hazelcast-cr branch August 16, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants