[CN-1049] Skip validations on MC and HZ deletion #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagric0
added
the
fix
ghost
requested review from
semihbkgr
approved these changes
Nov 1, 2023
SeriyBg
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before HZ and MC deletion, we are removing finalizer and updating the CR. Thus, webhook's ValidateUpdate function is triggered for them. If there is a broken state for the CR, we were not able to remove finalizer and stuck at the ValidateUpdate function. In order to solve this issue, we add a check to the function. If the CR is marked as deleted(using DeletionTimestamp), we skip the validation.