Fix Spring session fixation&stale session issues #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two problems solved: - Fix session fixation vulnerability - Fix stale Hazelcast session issue Session fixation vulnerability occurred with Spring Security MVC as it used isRequestedSessionIdValid method on HttpServletRequest interface which was not implemented before this commit. Stale Hazelcast session issue occurs when a request comes in with a valid JSESSIONID and a hazelcast.sessionId that corresponds to another Hazelcast session. In this case, we just used the existing session and used the incoming JSESSIONID to find the corresponding hazelcast.sessionId and Hazelcast session. Now we let the incoming hazelcast.sessionId to override the hazelcast.sessionId that corresponds to the request's JSESSIONID. Fix #47
|
Test PASSed. |
|
Test PASSed. |
emre-aydin
changed the title
emre-aydin
changed the title
hasancelik
approved these changes
Jul 21, 2017
mesutcelik
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems solved:
Session fixation vulnerability occurred with Spring Security MVC
as it used isRequestedSessionIdValid method on HttpServletRequest
interface which was not implemented before this commit.
Stale Hazelcast session issue occurs when a request comes in with a
valid JSESSIONID and a hazelcast.sessionId that corresponds to
another Hazelcast session. In this case, we just used the existing
session and used the incoming JSESSIONID to find the corresponding
hazelcast.sessionId and Hazelcast session. Now we let the incoming
hazelcast.sessionId to override the hazelcast.sessionId that
corresponds to the request's JSESSIONID.
Fix #47