Skip to content

Commit

Permalink
Servers throw exception when gets unkown message type
Browse files Browse the repository at this point in the history
fixes #10196
  • Loading branch information
sancar committed Mar 31, 2017
1 parent 43f094e commit 2d5343c
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 2 deletions.
@@ -0,0 +1,63 @@
/*
* Copyright (c) 2008-2017, Hazelcast, Inc. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.hazelcast.client;

import com.hazelcast.client.impl.HazelcastClientInstanceImpl;
import com.hazelcast.client.impl.protocol.ClientMessage;
import com.hazelcast.client.impl.protocol.codec.MapSizeCodec;
import com.hazelcast.client.spi.impl.ClientInvocation;
import com.hazelcast.client.test.ClientTestSupport;
import com.hazelcast.client.test.TestHazelcastFactory;
import com.hazelcast.core.HazelcastInstance;
import com.hazelcast.test.HazelcastParallelClassRunner;
import com.hazelcast.test.annotation.ParallelTest;
import com.hazelcast.test.annotation.QuickTest;
import com.hazelcast.util.ExceptionUtil;
import org.junit.After;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;


@RunWith(HazelcastParallelClassRunner.class)
@Category({QuickTest.class, ParallelTest.class})
public class ClientProtocolTest extends ClientTestSupport {

private final TestHazelcastFactory hazelcastFactory = new TestHazelcastFactory();

@After
public void cleanup() {
hazelcastFactory.terminateAll();
}

@Test(expected = UnsupportedOperationException.class)
public void testUnsupportedClientMessage() {
hazelcastFactory.newHazelcastInstance();
HazelcastInstance client = hazelcastFactory.newHazelcastClient();
HazelcastClientInstanceImpl clientImpl = getHazelcastClientInstanceImpl(client);
ClientMessage s = MapSizeCodec.encodeRequest("mapName");
int undefinedMessageType = Short.MAX_VALUE - 1;
s.setMessageType(undefinedMessageType);
ClientInvocation invocation = new ClientInvocation(clientImpl, s);
try {
invocation.invoke().get();
} catch (Exception e) {
throw ExceptionUtil.rethrow(e);
}
}
}

Expand Up @@ -44,8 +44,10 @@ protected ClientMessage encodeResponse(Object response) {

@Override
protected void processMessage() {
logger.warning("Unrecognized client message received with type: 0x"
+ Integer.toHexString(parameters.getMessageType()));
String message = "Unrecognized client message received with type: 0x"
+ Integer.toHexString(parameters.getMessageType());
logger.warning(message);
throw new UnsupportedOperationException(message);
}

@Override
Expand Down

0 comments on commit 2d5343c

Please sign in to comment.