Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionPredicate not respecting indices #13563

Open
pveentjer opened this issue Aug 13, 2018 · 5 comments
Open

PartitionPredicate not respecting indices #13563

pveentjer opened this issue Aug 13, 2018 · 5 comments
Assignees
@taburet
Labels
Module: IMap Module: Query Priority: Medium Source: Internal PR or issue was opened by an employee Team: Core Type: Perf. Defect
Milestone
Backlog

Comments

@pveentjer
Copy link
Contributor

So when a map is configured with binary in memory format and an index is configured, the index works fine if map.entrySet(predicate) is called (very good performance).

However when a partition predicate is used, the performance seems to be terrible.
@pveentjer
Copy link
Contributor Author

I believe this is a client related issue. The partitionpredicate wrapper isn't removed; the original predicate is send to the remote side and since it isn't an IndexAwarePredicate, the index isn't used.

@pveentjer pveentjer added this to the 3.11 milestone Aug 13, 2018
@pveentjer
Copy link
Contributor Author

I'm not sure if the client is the cause. On the server the partition predicate envelope should be removed and have similar problem with lite members.

@taburet
Copy link
Contributor

taburet commented Aug 13, 2018

Most likely that is because of QueryPartitionOperation is not using indexes, which are global for on-heap storages, see https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/map/impl/query/QueryPartitionOperation.java#L42 .

@mmedenjak
Copy link
Contributor

For more details, see: #12351

@mmedenjak mmedenjak modified the milestones: 3.11, 3.12 Aug 27, 2018
@mmedenjak mmedenjak mentioned this issue Aug 27, 2018
Open
@mmedenjak mmedenjak added Module: Query Source: Internal PR or issue was opened by an employee labels Aug 27, 2018
@mmedenjak mmedenjak modified the milestones: 3.12, 3.13 Jan 28, 2019
@taburet taburet self-assigned this Apr 1, 2019
@taburet taburet mentioned this issue Apr 2, 2019
Closed
@mmedenjak mmedenjak modified the milestones: 3.13, 4.0 Apr 17, 2019
@mmedenjak mmedenjak modified the milestones: 4.0, 4.1 Oct 24, 2019
@Holmistr Holmistr modified the milestones: 4.1, 4.2 Aug 25, 2020
@mmedenjak
Copy link
Contributor

Since we're heavily invested in the new query engine, I don't think we should spend too much time on this.

@mmedenjak mmedenjak modified the milestones: 4.2, Backlog Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taburet taburet

Labels
Module: IMap Module: Query Priority: Medium Source: Internal PR or issue was opened by an employee Team: Core Type: Perf. Defect
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Use global indexes for partition queries
4 participants
@pveentjer @taburet @Holmistr @mmedenjak