Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapEvictionPolicy is not configured via giving class name of custom eviction policy at PCF #14092

Closed
hasancelik opened this issue Nov 9, 2018 · 3 comments
Closed

mapEvictionPolicy is not configured via giving class name of custom eviction policy at PCF #14092

hasancelik opened this issue Nov 9, 2018 · 3 comments
Labels
Module: Config Module: IMap [OLD]Team: Integration Priority: High Source: Internal PR or issue was opened by an employee Team: Core
Milestone
3.12

Comments

@hasancelik
Copy link
Contributor

I was trying to reproduce/fix #14086, realized that mapEvictionPolicy is not configurable from JSON file. Creating instance from the configured class is executed by XMLConfigBuilder so we need similar logic for JSON config:

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/config/XmlConfigBuilder.java#L1435
@hasancelik hasancelik added this to the 3.12 milestone Nov 9, 2018
@mmedenjak
Copy link
Contributor

Should be covered by https://hazelcast.atlassian.net/wiki/spaces/PM/pages/1190035695/YAML+Configuration+Support.

@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Nov 30, 2018
@mmedenjak
Copy link
Contributor

@blazember @hasancelik can this issue be closed, given that YAML support is merged?

@mmedenjak mmedenjak modified the milestones: 3.12, 3.13 Feb 25, 2019
@blazember
Copy link
Contributor

I think this issue can be closed, the test covering evictionPolicy is passing: https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/test/java/com/hazelcast/config/YamlConfigBuilderTest.java#L1092-L1113

@mmedenjak mmedenjak modified the milestones: 3.13, 3.12 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: Config Module: IMap [OLD]Team: Integration Priority: High Source: Internal PR or issue was opened by an employee Team: Core
Projects
None yet
Milestone
3.12
Development

No branches or pull requests
3 participants
@blazember @hasancelik @mmedenjak