Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientMessageProtectionTest.testAccumulatedMessageSizeOverflow #15658

Closed
tezc opened this issue Oct 2, 2019 · 3 comments
Closed

ClientMessageProtectionTest.testAccumulatedMessageSizeOverflow #15658

tezc opened this issue Oct 2, 2019 · 3 comments
Assignees
@mdumandag
Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Test-Failure
Milestone
4.0

Comments

@tezc
Copy link
Contributor

tezc commented Oct 2, 2019

master (commit ea8293d)

http://jenkins.hazelcast.com/view/Official%20Builds/job/Hazelcast-3.x-ZingJDK8/92/testReport/com.hazelcast.client.protocol/ClientMessageProtectionTest/testAccumulatedMessageSizeOverflow/

Stacktrace

java.lang.AssertionError: Expected test to throw an instance of java.io.EOFException
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.rules.ExpectedException.failDueToMissingException(ExpectedException.java:263)
	at org.junit.rules.ExpectedException.access$200(ExpectedException.java:106)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:245)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at com.hazelcast.test.HazelcastParallelClassRunner.access$301(HazelcastParallelClassRunner.java:49)
	at com.hazelcast.test.HazelcastParallelClassRunner$TestRunner.run(HazelcastParallelClassRunner.java:162)
	at java.lang.Thread.run(Thread.java:745)

20:30:48,156  WARN |testExceededMessageSize| - [TcpIpConnection] hz.frosty_hopper.IO.thread-in-0 - [127.0.0.1]:5306 [testExceededMessageSize] [4.0-SNAPSHOT] Connection[id=1, /127.0.0.1:5306->/127.0.0.1:34202, qualifier=null, endpoint=null, alive=false, type=NONE] closed. Reason: Exception in Connection[id=1, /127.0.0.1:5306->/127.0.0.1:34202, qualifier=null, endpoint=null, alive=true, type=NONE], thread=hz.frosty_hopper.IO.thread-in-0
com.hazelcast.client.impl.protocol.exception.MaxMessageSizeExceeded: The client message size (108 + 806) exceededs the maximum allowed length (800)
	at com.hazelcast.client.impl.protocol.ClientMessageReader.readFrame(ClientMessageReader.java:82) ~[classes/:?]
	at com.hazelcast.client.impl.protocol.ClientMessageReader.readFrom(ClientMessageReader.java:45) ~[classes/:?]
	at com.hazelcast.client.impl.protocol.util.ClientMessageDecoder.onRead(ClientMessageDecoder.java:81) ~[classes/:?]
	at com.hazelcast.internal.networking.nio.NioInboundPipeline.process(NioInboundPipeline.java:131) ~[classes/:?]
	at com.hazelcast.internal.networking.nio.NioThread.processSelectionKey(NioThread.java:368) [classes/:?]
	at com.hazelcast.internal.networking.nio.NioThread.processSelectionKeys(NioThread.java:353) [classes/:?]
	at com.hazelcast.internal.networking.nio.NioThread.selectLoop(NioThread.java:279) [classes/:?]
	at com.hazelcast.internal.networking.nio.NioThread.run(NioThread.java:234) [classes/:?]

Looks like related with : #15396
@tezc tezc added Team: Client Type: Test-Failure Source: Internal PR or issue was opened by an employee labels Oct 2, 2019
@tezc tezc added this to the 4.0 milestone Oct 2, 2019
@mdogan
Copy link
Contributor

mdogan commented Oct 3, 2019

http://jenkins.hazelcast.com/job/Hazelcast-pr-builder/3545/testReport/junit/com.hazelcast.client.protocol/ClientMessageProtectionTest/testAccumulatedMessageSizeOverflow/

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Oct 4, 2019
@ihsandemir
Ignored test `com.hazelcast.client.protocol.ClientMessageProtectionTe…
4879718 
…st.testAccumulatedMessageSizeOverflow` per issue hazelcast#15658
ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Oct 4, 2019
@ihsandemir
Ignored test `com.hazelcast.client.protocol.ClientMessageProtectionTe…
78a72e8 
…st.testAccumulatedMessageSizeOverflow` per issue hazelcast#15658
ihsandemir added a commit that referenced this issue Oct 4, 2019
@ihsandemir
Remove LinkedList usage in ClientMessage (#15652)
404f329 
* Changed the ClientMessage so that it is no longer a LinkedList which may produce too much litter. Used next and previous pointer fields in Frame class to navigate between Frames. I had to write a new FrameIterator class which acts similar to ListIterator but with less litter. Regenerated all the codecs with this updated iterator.

One drawback was to shallow copy NULL_FRAME, BEGIN_FRAME, END_FRAME kind of static Frames which were not being copied before, since we need instance specific next and previous pointers.

* Ignored test `com.hazelcast.client.protocol.ClientMessageProtectionTest.testAccumulatedMessageSizeOverflow` per issue #15658
@tezc
Copy link
Contributor Author

tezc commented Oct 10, 2019

http://jenkins.hazelcast.com/view/Official%20Builds/job/Hazelcast-3.x-OracleJDK9/43/testReport/com.hazelcast.client.protocol/ClientMessageProtectionTest/testExceededMessageSize/

@mdumandag mdumandag mentioned this issue Oct 11, 2019
Closed
@mdumandag
Copy link
Contributor

fixed by #15772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdumandag mdumandag

Labels
Source: Internal PR or issue was opened by an employee Team: Client Type: Test-Failure
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

correct the frame to byte conversion logic in ClientMessageProtection… mdumandag/hazelcast
3 participants
@mdogan @tezc @mdumandag