Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/start.sh only allows one process #15831

Closed
dbrimley opened this issue Oct 21, 2019 · 3 comments
Closed

bin/start.sh only allows one process #15831

dbrimley opened this issue Oct 21, 2019 · 3 comments
Labels
Milestone

Comments

@dbrimley
Copy link
Contributor

dbrimley commented Oct 21, 2019

Try starting two hazelcast instances using the ./bin/start.sh script.

Because there is only very basic PID management it fails and asks the user to create another copy of the bin directory. This is poor user experience.

I've tested other distributions from Redis and Kafka. They provide more advanced PID management that allows running multiple processes.

Allow start.sh to run more processes without the need to copy the bin directory. In hand with this the /bin/stop.sh script should take a PID.

@dbrimley dbrimley added this to the 4.0 milestone Oct 21, 2019
@pveentjer
Copy link
Contributor

pveentjer commented Oct 22, 2019

Will this not cause issues with e.g. logging? So having 2 or more Hazelcast processes sharing the logging directory. If the log filesnames are unique, it is ok, but if they are not then there could be a serious problem.

@dbrimley
Copy link
Contributor Author

Hazelcast Jet allows multiple processes to be started, it doesn't store any pid state on the file system. The stop script just greps for Jet processes and kills them all in one go.

@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Nov 6, 2019
alparslanavci added a commit that referenced this issue Nov 8, 2019
Removed PID management from start/stop scripts
@alparslanavci
Copy link
Contributor

Fixed by #15934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants