Exception encountered by TimedMemberStateFactory stops MC service

[blazember]

ManagementCenterService shuts down itself if it encounters an exception when creating the TimedMemberState. This issue makes the cluster to disappear from MC. The related code is here:

hazelcast/hazelcast/src/main/java/com/hazelcast/internal/management/ManagementCenterService.java

Lines 447 to 460 in 91ae6c3

	public void run() {
	try {
	while (isRunning()) {
	timedMemberState.set(timedMemberStateFactory.createTimedMemberState());
	sleep();
	}
	} catch (Throwable throwable) {
	inspectOutOfMemoryError(throwable);
	if (!(throwable instanceof InterruptedException)) {
	logger.warning("Hazelcast Management Center Service will be shutdown due to exception.", throwable);
	shutdown();
	}
	}
	}

This happens even if the exception is a retryable one such as in this case:

[127.0.0.1]:5702 [A] [4.0-SNAPSHOT] Hazelcast Management Center Service will be shutdown due to exception.
com.hazelcast.spi.exception.RetryableHazelcastException: HazelcastInstance[[127.0.0.1]:5702] is not active!
    at com.hazelcast.spi.impl.NodeEngineImpl.getService(NodeEngineImpl.java:385) ~[hazelcast-4.0-SNAPSHOT.jar:4.0-SNAPSHOT]
    at com.hazelcast.internal.management.TimedMemberStateFactory.getCacheService(TimedMemberStateFactory.java:422) ~[hazelcast-4.0-SNAPSHOT.jar:4.0-SNAPSHOT]
    at com.hazelcast.internal.management.TimedMemberStateFactory.createMemState(TimedMemberStateFactory.java:278) ~[hazelcast-4.0-SNAPSHOT.jar:4.0-SNAPSHOT]
    at com.hazelcast.internal.management.TimedMemberStateFactory.createMemberState(TimedMemberStateFactory.java:200) ~[hazelcast-4.0-SNAPSHOT.jar:4.0-SNAPSHOT]
    at com.hazelcast.internal.management.TimedMemberStateFactory.createTimedMemberState(TimedMemberStateFactory.java:126) ~[hazelcast-4.0-SNAPSHOT.jar:4.0-SNAPSHOT]
    at com.hazelcast.internal.management.ManagementCenterService$PrepareStateThread.run(ManagementCenterService.java:450) [hazelcast-4.0-SNAPSHOT.jar:4.0-SNAPSHOT]

Related closed issue #15656

[blazember]

cc @emre-aydin @puzpuzpuz

[puzpuzpuz]

@emre-aydin @blazember should we close this issue now, as #15980 was merged?

[emre-aydin]

@emre-aydin @blazember should we close this issue now, as #15980 was merged?

Yes we should.

[puzpuzpuz]

I'm closing this issue, as #15980 was merged