Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file should support ".yml" as a default extension as well as ".yaml" #16205

Closed
neilstevenson opened this issue Dec 6, 2019 · 3 comments · Fixed by #16377
Closed

Config file should support ".yml" as a default extension as well as ".yaml" #16205

neilstevenson opened this issue Dec 6, 2019 · 3 comments · Fixed by #16377
Assignees
@neilstevenson
Labels
Module: Config Source: Internal PR or issue was opened by an employee Team: Core Type: Enhancement
Milestone
4.0

Comments

@neilstevenson
Copy link
Contributor

Default config location will find hazelcast.yaml and hazelcast.xml on the classpath but not hazelcast.yml.

Same for client hazelcast-client.yaml and hazelcast-client.xml but not hazelcast-client.yml

".yaml" and ".yml" are commonly used, so both should be supported
@neilstevenson neilstevenson self-assigned this Dec 6, 2019
@neilstevenson
Copy link
Contributor Author

Vaguely related #14924

@mmedenjak
Copy link
Contributor

We'll consider this an enhancement. Moving into 4.1 as it's not a 4.0 blocker. cc @blazember

@mmedenjak mmedenjak added this to the 4.1 milestone Dec 9, 2019
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Dec 24, 2019
@neilstevenson
Copy link
Contributor Author

See #16377

This was referenced Dec 30, 2019
Merged
Closed
blazember pushed a commit that referenced this issue Jan 8, 2020
@neilstevenson @blazember
ConfigLocators to resolve .yml from workdir and classpath (#16377)
4a05270 
Fixes #16205
@mmedenjak mmedenjak modified the milestones: 4.1, 4.0 Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neilstevenson neilstevenson

Labels
Module: Config Source: Internal PR or issue was opened by an employee Team: Core Type: Enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Issue 16205
2 participants
@neilstevenson @mmedenjak