Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External config override on advance networking public address looks also to override/default config element in same level #17681

Closed
ghost opened this issue Oct 5, 2020 · 0 comments · Fixed by #17878
Assignees
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Oct 5, 2020

  • Member have initial config as given below under advance-network
<client-server-socket-endpoint-config>
            <port auto-increment="false">9000</port>
            <public-address>172.29.1.1</public-address>
        </client-server-socket-endpoint-config>
  • We override given config with below
-Dhz.advanced-network.client-server-socket-endpoint-config.public-address=172.29.1.1
<client-server-socket-endpoint-config>
            <port auto-increment="false">9000</port>
            <public-address>255.255.255.0</public-address>
        </client-server-socket-endpoint-config>
  • Logs indicate that bound port value is 5702 ⚠️
2020-10-05T11:03:13.149982678Z INFO: Detected external configuration overrides in system properties: [hazelcast.advanced-network.client-server-socket-endpoint-config.public-address=172.29.1.1]
2020-10-05T11:03:13.292829351Z Oct 05, 2020 11:03:13 AM com.hazelcast.instance.AddressPicker
2020-10-05T11:03:13.292855309Z INFO: [LOCAL] [dev] [4.1-advancednetworkit] Interfaces is enabled, trying to pick one address matching to one of: [172.28.1.1, 172.28.*.*]
2020-10-05T11:03:13.326795232Z Oct 05, 2020 11:03:13 AM com.hazelcast.instance.AddressPicker
2020-10-05T11:03:13.326836470Z INFO: [LOCAL] [dev] [4.1-advancednetworkit] Interfaces is disabled, trying to pick one address from TCP-IP config addresses: [172.28.1.1]
2020-10-05T11:03:13.329808389Z Oct 05, 2020 11:03:13 AM com.hazelcast.instance.AddressPicker
2020-10-05T11:03:13.329830514Z INFO: [LOCAL] [dev] [4.1-advancednetworkit] Using public address: [172.29.1.1]:5702
2020-10-05T11:03:13.490705648Z Oct 05, 2020 11:03:13 AM com.hazelcast.system
  • Below are the logs when we run w/out overriding config with proper public address, it binds to configured port as 9000, yet when overridden only public address it binds to 5702
2020-10-05T11:09:24.668201216Z INFO: [LOCAL] [dev] [4.1-advancednetworkit] Interfaces is enabled, trying to pick one address matching to one of: [172.28.1.1, 172.28.*.*]
2020-10-05T11:09:24.679077349Z Oct 05, 2020 11:09:24 AM com.hazelcast.instance.AddressPicker
2020-10-05T11:09:24.679108009Z INFO: [LOCAL] [dev] [4.1-advancednetworkit] Interfaces is disabled, trying to pick one address from TCP-IP config addresses: [172.28.1.1]
2020-10-05T11:09:24.679817266Z Oct 05, 2020 11:09:24 AM com.hazelcast.instance.AddressPicker
2020-10-05T11:09:24.679831147Z INFO: [LOCAL] [dev] [4.1-advancednetworkit] Using public address: [172.29.1.1]:9000
@ghost ghost added Type: Defect Team: Core Source: Internal PR or issue was opened by an employee Module: Config labels Oct 5, 2020
@ghost ghost added this to the 4.1 milestone Oct 5, 2020
@ghost ghost assigned pivovarit Oct 5, 2020
@ghost ghost changed the title External config override on advance networking public address looks also to override config element in same level External config override on advance networking public address looks also to override/default config element in same level Oct 5, 2020
@mmedenjak mmedenjak modified the milestones: 4.1, 4.2 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants