Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapStoreConfig enabled initial value inconsistency #18216

Closed
blazember opened this issue Feb 15, 2021 · 0 comments · Fixed by #18217
Closed

MapStoreConfig enabled initial value inconsistency #18216

blazember opened this issue Feb 15, 2021 · 0 comments · Fixed by #18217
Assignees
@blazember
Labels
Module: Config Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Milestone
4.2

Comments

@blazember
Copy link
Contributor

If map-store is configured in the declarative config it is disabled unless enabled="true" is explicitly set. With the external config override, we reuse the default MapConfig.MapStoreConfig, which has enabled set to false. This makes sense since the map store shouldn't be enabled unless it's explicitly configured so. In MemberDomConfigProcessor MapStoreConfig.enabled should be set to true unless enabled="false" is explicitly set in the declarative config.
@blazember blazember added this to the 4.2 milestone Feb 15, 2021
@blazember blazember self-assigned this Feb 15, 2021
blazember added a commit to blazember/hazelcast that referenced this issue Feb 15, 2021
@blazember
Enable map store config unless its disabled explicitly
e4da790 
Fixes hazelcast#18216
@blazember blazember mentioned this issue Feb 15, 2021
Merged
@vbekiaris vbekiaris added the Source: Internal PR or issue was opened by an employee label Feb 16, 2021
@blazember blazember mentioned this issue Feb 16, 2021
Closed
blazember added a commit that referenced this issue Feb 16, 2021
@blazember
Enable map store config unless its disabled explicitly (#18217)
778c030 
Fixes #18216
@ramizdundar ramizdundar mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blazember blazember

Labels
Module: Config Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Enable map store config unless its disabled explicitly blazember/hazelcast
2 participants
@vbekiaris @blazember