Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring support for Runnable tasks #244

Closed
leimer opened this issue Aug 15, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@leimer
Copy link
Contributor

commented Aug 15, 2012

It would be nice if we had Spring support in Runnable tasks. Currently this @SpringAware is not recognized by SpringManagedContext because the Runnable is wrapped into a DistributedRunnableAdapter.

@leimer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2012

pull request #243 contains now a fix for this issue too.

I'd like to mention, that DistributedRunnableAdapter is now a mutable interface!
There are two other ways to achieve the initialization of the Runnable:

  • Reflection: In my opinion this is the most ugly way because it exposes implementation details and is not trackable.
  • new DistributedRunnableAdapter: This would be preserve the immutability of the adapter, but we have to take care that everything gets copied into the new instance. Additionally every change in the adapter has to be respected in SpringManagedContext as well.

This considerations are the reasons for my implementation. Are you with me?

@mdogan

This comment has been minimized.

Copy link
Member

commented Aug 15, 2012

I'm ok with your implementation.

Thanks for the patch.

@mdogan mdogan closed this Aug 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.