Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.hazelcast.client.impl.protocol.task.dynamicconfig.AddWanBatchPublisherConfigMessageTaskTest.testWanConfig [HZ-4565] #26279

Closed
Patras3 opened this issue Mar 6, 2024 · 1 comment
Closed

com.hazelcast.client.impl.protocol.task.dynamicconfig.AddWanBatchPublisherConfigMessageTaskTest.testWanConfig [HZ-4565] #26279

Patras3 opened this issue Mar 6, 2024 · 1 comment
Labels
Module: WAN Source: Internal PR or issue was opened by an employee Team: Client to-jira Type: Test-Failure
Milestone
5.5.0

Comments

@Patras3
Copy link
Contributor

Patras3 commented Mar 6, 2024

master (commit 0afa6ae72e3267c66c21d3095c922d4cf5d28be1)

Failed on zing-21: https://jenkins.hazelcast.com/job/Hazelcast-master-ZingJDK21/6/testReport/com.hazelcast.client.impl.protocol.task.dynamicconfig/AddWanBatchPublisherConfigMessageTaskTest/testWanConfig/

Stacktrace: 
Wanted but not invoked:
wanReplicationService.addWanReplicationConfig(
    <Capturing argument: WanReplicationConfig>
);
-> at com.hazelcast.client.impl.protocol.task.dynamicconfig.AddWanBatchPublisherConfigMessageTaskTest.testWanConfig(AddWanBatchPublisherConfigMessageTaskTest.java:53)
Actually, there were zero interactions with this mock.

	at com.hazelcast.client.impl.protocol.task.dynamicconfig.AddWanBatchPublisherConfigMessageTaskTest.testWanConfig(AddWanBatchPublisherConfigMessageTaskTest.java:53)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.hazelcast.test.FailOnTimeoutStatement$CallableStatement.call(FailOnTimeoutStatement.java:115)
	at com.hazelcast.test.FailOnTimeoutStatement$CallableStatement.call(FailOnTimeoutStatement.java:107)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.lang.Thread.run(Thread.java:1584)
Standard output: 
Started Running Test: testWanConfig

Standard output can be found here - https://s3.console.aws.amazon.com/s3/buckets/j-artifacts/Hazelcast-master-ZingJDK21/6/
@Patras3 Patras3 added this to the 5.5 Backlog milestone Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Internal Jira issue: HZ-4565

@github-actions github-actions bot changed the title com.hazelcast.client.impl.protocol.task.dynamicconfig.AddWanBatchPublisherConfigMessageTaskTest.testWanConfig com.hazelcast.client.impl.protocol.task.dynamicconfig.AddWanBatchPublisherConfigMessageTaskTest.testWanConfig [HZ-4565] Mar 8, 2024
devOpsHazelcast pushed a commit that referenced this issue Mar 19, 2024
@JackPGreen @actions-user
Potential Mockito/Azul issue fix for `AddWanBatchPublisherConfigMessa…
ffa1d33 
…geTaskTest` [HZ-4565] (#1128)

[Several tests are
failing](https://hazelcast.atlassian.net/browse/HZ-2245) only on Azul
Prime JDKs due to an incompatibility between it and Mockito.

In https://github.com/hazelcast/hazelcast-mono/pull/845 it was
discovered that a causal factor was mocking classes, not interfaces.

To address this:
- `AbstractMessageTask` refactored to not exclusively require a `Node`
(the problematic mocked class)
    - instead the elements required from `Node` can be supplied instead
- `AddWanBatchPublisherConfigMessageTaskTest` and related classes
refactored to use these new constructors
- Further replaced implementations with interfaces _where possible_

*Unable* to reproduce this issue locally to test if this will resolve
the issue.

Fixes: [HZ-4565](https://hazelcast.atlassian.net/browse/HZ-4565),
#26279

[HZ-4565]:
https://hazelcast.atlassian.net/browse/HZ-4565?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

GitOrigin-RevId: b3d0ee2866e9438f9fe077d10a8baab1e7ce4a9c
@AyberkSorgun AyberkSorgun modified the milestones: 5.5 Backlog, 5.5.0 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: WAN Source: Internal PR or issue was opened by an employee Team: Client to-jira Type: Test-Failure
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
3 participants
@JackPGreen @AyberkSorgun @Patras3