NearCacheConfig.readData reads "maxSize" twice

[serkan-ozal]

    public void readData(ObjectDataInput in) throws IOException {
        ...
        maxSize = in.readInt();
        maxSize = in.readInt();
        ...
    }

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/config/NearCacheConfig.java

[Donnerbart]

Code like that should always be suspicious. Looks like a good thing for checkstyle or FindBugs rule.

[jerrinot]

how this could ever worked?

[serkan-ozal]

node idea. I found this while writing unit test for my near cache impl on client

[ahmetmircik]

Why is NearCacheConfig serializable?

[serkan-ozal]

AFAIK, when the cache is created at client side such as cacheManager.createCache(cacheName, cacheConfig) as dynamic, CacheConfig is send over CacheCreateConfigRequest and also there is NearCacheConfig inside CacheConfig. And so they are all serialized to nodes

[ahmetmircik]

Thanks @serkan-ozal i did not know it is used in jcache.

[serkan-ozal]

@ahmetmircik you are welcome. It was defined in CacheConfig but always null since we didn't use it for JCache as I know :) So I think, because of it was not used/set, it was not serialized so there was no error until now.