wrong ClientExecutionService usages restored. #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
force-pushed
the
fix/internalAndUserExecutorUsages/master
branch
from
a6c0f47
to
6661958
Compare
|
Test PASSed. |
sancar
force-pushed
the
fix/internalAndUserExecutorUsages/master
branch
from
6661958
to
8d387a0
Compare
Parts that violates following rules are fixed. User code (listener and callback) runs on userExecutor Other internals runs on internalExecutor To avoid further confusion about usages made the following chamnges 1. Made ClientExecutionService to use only internalExecutor when used over its methods. 2. Removed getInternalExecutor to avoid doing same thing two different ways. 3. Renamed getAsyncExecutor to getUserExecutor to avoid confusion 4. Used getUserExecutor where needed to fix current wrong usages.
|
Test PASSed. |
sancar
changed the title
asimarslan
approved these changes
Mar 10, 2017
ihsandemir
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts that violates following rules are fixed.
User code (listener and callback) runs on userExecutor
Other internals runs on internalExecutor
To avoid further confusion about usages made the following changes
fixes #8651