BounceMemberRule logging & fixes, smaller cluster in QueryBounceTest #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbekiaris
force-pushed
the
fixes/3.9/query-bounce-test
branch
from
0d5c2bf
to
8b18afd
Compare
|
Test PASSed. |
Donnerbart
reviewed
Mar 30, 2017
| @@ -363,25 +388,33 @@ public void evaluate() throws Throwable { | |||
|
|
|||
| // wait until all test tasks complete or one of them throws an exception | |||
| private void waitForFutures(Future[] futures) { | |||
| // do not wait more than 30 seconds | |||
| long deadline = currentTimeMillis() + 30 * 1000; | |||
There was a problem hiding this comment.
I would make the timout a constant like TIMEOUT_SECONDS and use TimeUnit.Seconds.toMillis(TIMEOUT_SECONDS) here (and of course use the constant in the comment and warning log below as well).
vbekiaris
force-pushed
the
fixes/3.9/query-bounce-test
branch
from
8b18afd
to
e50de90
Compare
|
|
Test PASSed. |
- Smaller cluster and test drivers size in QueryBounceTest to reduce probability of timeout - Added logging in BounceMemberRule for easier troubleshooting - Bounced members and test drivers with volatile read/write, as they are accessed by several threads - Bounce member thread is now a daemon thread
vbekiaris
force-pushed
the
fixes/3.9/query-bounce-test
branch
from
e50de90
to
5c4ca03
Compare
… QueryRunnable execution
vbekiaris
force-pushed
the
fixes/3.9/query-bounce-test
branch
from
5c4ca03
to
712443d
Compare
|
Test PASSed. |
|
run-lab-run |
|
Test PASSed. |
Donnerbart
approved these changes
Apr 20, 2017
|
thanks @mdogan @Donnerbart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Test(timeout=...).AbstractHazelcastClassRunner(eg when running within the IDE this is themainthread)FailOnTimeoutStatementthat wraps every test to enforce the timeout spawns a separate thread that invokes the test method.BounceMemberRule.test*will be invoked from this thread and will typically need to obtain at least a test driverHazelcastInstanceBounceMemberRulethat executes the member bouncing logic and updates the current cluster members inBounceMemberRule.members