Use inherited runner in MembershipFailureTest_withTCP #11122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The superclass uses a Parametrized test and when it's overwritten the the parametrized field is null
We do not require non-nightly tests to end with Test. So requiring this for nighly test is surprising and as a result some tests were not executed.
metanet
approved these changes
Aug 17, 2017
mdogan
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11119
Also the same file pattern when search for nightly tests as for quick test. I believe the
MembershipFailureTest_withTCPwas never executed on Jenkins due not ending with-Testsuffix. That's why @Donnerbart discovered the NPE when running it locally.