Improved message of VersionMismatchException in validateJoinRequest() #11603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added a hint that Rolling Member Upgrades are only supported in Hazelcast Enterprise * added a hint that Rolling Member Upgrades are only supported for same major versions * added a hint that Rolling Member Upgrades are only supported for the next minor version
vbekiaris
approved these changes
Oct 18, 2017
Holmistr
approved these changes
Oct 18, 2017
There was a problem hiding this comment.
Very nice, much clearer now.
One concern that comes to my mind is that when the exception is thrown and the node doesn't get joined, you can see only WARNING in the logs. I think this is a proper ERROR situation. However, I'm approving this since it's not critical, but maybe something that should be kept in mind for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples:
VersionMismatchException: Joining node's version 3.11.0 is not compatible with cluster version 3.10 (Rolling Member Upgrades are only supported in Hazelcast Enterprise)VersionMismatchException: Joining node's version 3.9.0 is not compatible with cluster version 3.10 (Rolling Member Upgrades are only supported for the next minor version) (Rolling Member Upgrades are only supported in Hazelcast Enterprise)VersionMismatchException: Joining node's version 4.10.0 is not compatible with cluster version 3.10 (Rolling Member Upgrades are only supported for the same major version) (Rolling Member Upgrades are only supported in Hazelcast Enterprise)Fixes #11602