Clear schedulers for ttl upon clear of replicated-map otherwise memory leaks #13416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmircik
requested review from
eminn,
mmedenjak and
Donnerbart
and removed request for
eminn
Donnerbart
reviewed
Jul 6, 2018
| storage.clear(); | ||
| storage.incrementVersion(); | ||
| getStats().incrementOtherOperations(); | ||
| clearInternal(); |
There was a problem hiding this comment.
Hmm, is this missing the .incrementVersion() call?
There was a problem hiding this comment.
oops! nice catch. fixed.
ahmetmircik
force-pushed
the
fix/3.10.3/replicatedMapClearSchedular
branch
from
55e7ccf
to
a2bcdfd
Compare
Donnerbart
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13409