[BACKPORT] Fixes retention issue on IOBalancer. #13761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pveentjer
added
Type: Defect
Team: Core
Priority: High
Source: Internal
pveentjer
force-pushed
the
v3.10.6/fix/iobalancer-task-retention
branch
from
0e4eeec
to
ad6ffe7
Compare
pveentjer
changed the title
pveentjer
force-pushed
the
v3.10.6/fix/iobalancer-task-retention
branch
from
ad6ffe7
to
5ca2898
Compare
If connections get created very rapidly, tasks in the IOBalancer can accumulate and this can lead to retention of the NioChannel and its resources. This PR fixes that by processing tasks immediately in the IOBalancer when they arrive instead of waiting up to 20s.
pveentjer
force-pushed
the
v3.10.6/fix/iobalancer-task-retention
branch
from
5ca2898
to
81df7cb
Compare
sancar
approved these changes
Sep 14, 2018
jerrinot
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If connections get created very rapidly, tasks in the IOBalancer
can accumulate and this can lead to retention of the NioChannel
and its resources.
This PR fixes that by processing tasks immediately in the IOBalancer
when they arrive instead of waiting up to 20s.
backport of #13762