Make client work when addresses configured via different interface than members #14104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sancar
changed the title
sancar
force-pushed
the
fix/mixedAddressConfigSetups/master
branch
from
e7e72a8
to
0045241
Compare
ihsandemir
reviewed
Nov 13, 2018
| @@ -79,6 +81,7 @@ | |||
| this.connectionStrategy = connectionStrategy; | |||
| this.clusterConnectionExecutor = createSingleThreadExecutorService(client); | |||
| this.shuffleMemberList = client.getProperties().getBoolean(SHUFFLE_MEMBER_LIST); | |||
| this.userMemberListForDiscovery = client.getProperties().getBoolean(USE_MEMBER_LIST_FOR_DISCOVERY); | |||
There was a problem hiding this comment.
wording userMemberListForDiscovery --> useMemberListForDiscovery
sancar
force-pushed
the
fix/mixedAddressConfigSetups/master
branch
2 times, most recently
from
0593cb9
to
61fc76b
Compare
sancar
changed the title
|
run-lab-run |
sancar
changed the title
ihsandemir
approved these changes
Jan 31, 2019
asimarslan
approved these changes
Feb 6, 2019
sancar
changed the title
sancar
changed the title
asimarslan
approved these changes
Feb 8, 2019
ihsandemir
reviewed
Feb 8, 2019
...st-client/src/main/java/com/hazelcast/client/connection/nio/ClientConnectionManagerImpl.java
Show resolved
Hide resolved
ihsandemir
approved these changes
Feb 8, 2019
sancar
force-pushed
the
fix/mixedAddressConfigSetups/master
branch
from
aa10093
to
3ac1190
Compare
added 2 commits
February 8, 2019 16:11
…an members Clients and members were forced to configure use interface when adding a member address to config. This prd relaxes rules. As long as hostnames are resolved to same ip when dns lookup made on the client side following setups are allowed. 1. Member hostname <-> client different hostname 2. Member ip <-> client different hostname 3. Member hostname <-> client ip
1. This way, we will remove the need a new object creation on hot path. 2. We will have more consistent behaviour. Even if address resolution changes on jvm level, client will not be affected.
sancar
force-pushed
the
fix/mixedAddressConfigSetups/master
branch
from
3ac1190
to
5472cdd
Compare
This was referenced Feb 8, 2019
sancar
pushed a commit
to sancar/hazelcast
that referenced
this pull request
Feb 12, 2019
To keep the behaviour same, reverted the related line. Added a severe log to make user aware of the problem. follow up to hazelcast#14104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients and members were forced to configure use interface when
adding a member address to config.
This prd relaxes rules. As long as hostnames are resolved to same ip
when dns lookup made on the client side following setups are allowed.