[FORWARDPORT] Make comparators able to act on keys and values #15380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmedenjak
approved these changes
Jul 31, 2019
|
@taburet I think we can merge this with a single approval. WDYT? |
|
@mmedenjak it's better to review it, it's not a clean cherry-pick, mostly because the client code was merged into the core. |
petrpleshachkov
approved these changes
Aug 14, 2019
| @@ -444,6 +445,32 @@ public void testLargePageSizeIsNotCausingIndexOutBoundsExceptions() { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testCustomComparatorAbleToActOnKeysAndValues() { | |||
There was a problem hiding this comment.
It seems in the PagingPredicateTest we have exactly the same test. Can we somehow avoid code duplication?
There was a problem hiding this comment.
Merged member and client paging predicate tests together.
A custom paging predicate comparator may act on keys and values at the same time even if only the keys were requested, e.g. using `IMap.keySet` call. Before this fix only keys were fetched for `IMap.keySet`, making comparators unable to act on values.
taburet
force-pushed
the
fix/4.0/paging-predicate-comparators
branch
from
6037b49
to
ac88eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom paging predicate comparator may act on keys and values at the
same time even if only the keys were requested, e.g. using
IMap.keySetcall. Before this fix only keys were fetched for
IMap.keySet, makingcomparators unable to act on values.
Original maintenance PR: #15324