Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FORWARDPORT] Make comparators able to act on keys and values #15380

Merged

Conversation

@taburet
Copy link
Contributor

taburet commented Jul 26, 2019

A custom paging predicate comparator may act on keys and values at the
same time even if only the keys were requested, e.g. using IMap.keySet
call. Before this fix only keys were fetched for IMap.keySet, making
comparators unable to act on values.

Original maintenance PR: #15324

@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Aug 8, 2019

@taburet I think we can merge this with a single approval. WDYT?

@taburet

This comment has been minimized.

Copy link
Contributor Author

taburet commented Aug 9, 2019

@mmedenjak it's better to review it, it's not a clean cherry-pick, mostly because the client code was merged into the core.

@petrpleshachkov petrpleshachkov self-requested a review Aug 14, 2019
@@ -444,6 +445,32 @@ public void testLargePageSizeIsNotCausingIndexOutBoundsExceptions() {
}
}

@Test
public void testCustomComparatorAbleToActOnKeysAndValues() {

This comment has been minimized.

Copy link
@petrpleshachkov

petrpleshachkov Aug 14, 2019

Contributor

It seems in the PagingPredicateTest we have exactly the same test. Can we somehow avoid code duplication?

This comment has been minimized.

Copy link
@taburet

taburet Aug 20, 2019

Author Contributor

Merged member and client paging predicate tests together.

taburet added 2 commits Jul 26, 2019
A custom paging predicate comparator may act on keys and values at the
same time even if only the keys were requested, e.g. using `IMap.keySet`
call. Before this fix only keys were fetched for `IMap.keySet`, making
comparators unable to act on values.
@taburet taburet force-pushed the taburet:fix/4.0/paging-predicate-comparators branch from 6037b49 to ac88eb2 Aug 17, 2019
@taburet taburet merged commit 5fffd70 into hazelcast:master Aug 27, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@taburet taburet deleted the taburet:fix/4.0/paging-predicate-comparators branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.