Remove ILock, ICondition and their implementations #15625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdogan
force-pushed
the
remove-legacy-lock
branch
from
ac9e72d
to
2cb0776
Compare
sancar
approved these changes
Sep 30, 2019
mdogan
force-pushed
the
remove-legacy-lock
branch
from
2cb0776
to
7f0af9e
Compare
Old LockService is moved to internal `locksupport` package. It's still provides locking support to `IMap` and `MultiMap`.
metanet
approved these changes
Oct 2, 2019
mdogan
force-pushed
the
remove-legacy-lock
branch
from
7f0af9e
to
5954576
Compare
|
run-lab-run |
vojtechtoman
reviewed
Oct 2, 2019
| @@ -19,5 +19,5 @@ | |||
| * | |||
| * @since 1 | |||
| */ | |||
| package com.hazelcast.cp.internal.datastructures.unsafe.lock.operations; | |||
| package com.hazelcast.internal.locksupport.operations; | |||
There was a problem hiding this comment.
Javadoc still mentions ILock. Actually, there are more places that refer to ILock or ICondition if I search in the workspace:
./hazelcast/src/main/java/com/hazelcast/internal/locksupport/LockStoreImpl.java:50: // warning: the namespace field is unreliable if this LockStoreImpl was created for ILock proxy
./hazelcast/src/main/java/com/hazelcast/internal/locksupport/LockStoreImpl.java:52: // are shared for ILock proxies. see InternalLockNamespace for details.
./hazelcast/src/main/java/com/hazelcast/internal/locksupport/operations/package-info.java:18: * <p>This package contains the operations on the ILock.<br>
./hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/Operation.java:533: * <li>in case of ILock.tryLock(10, ms), the wait timeout is 10 ms</li>
./hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/Operation.java:534: * <li>in case of ILock.lock(), the wait timeout is -1</li>
./hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/Operation.java:535: * <li>in case of ILock.tryLock(), the wait timeout is 0.</li>
./hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/BlockingOperation.java:20: * An interface that can be implemented by an operation that can block. For example an ILock.acquire.
./hazelcast/src/main/java/com/hazelcast/spi/properties/GroupProperty.java:863: * - certain methods like those from the IExecutor or ILock are also invocations and they can be very long running.
./hazelcast/src/main/java/com/hazelcast/cp/internal/datastructures/lock/operation/package-info.java:19: * {@link com.hazelcast.cp.lock.ILock} implementation
./hazelcast/src/main/java/com/hazelcast/cp/internal/datastructures/lock/proxy/package-info.java:18: * Contains {@link com.hazelcast.cp.lock.ILock} functionality
./hazelcast/src/main/java/com/hazelcast/cp/internal/datastructures/lock/package-info.java:18: * Contains service classes for the Raft-based {@link com.hazelcast.cp.lock.ILock}
./hazelcast-spring/src/main/resources/hazelcast-spring-4.0.xsd:1793: Retrieve a Hazelcast ILock instance
./hazelcast-spring/src/main/resources/hazelcast-spring-4.0.xsd:1797: <tool:exports type="com.hazelcast.cp.lock.ILock"/>
./hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/WaitNotifyKey.java:20: * A key for a wait notify object e.g. an ICondition.
There was a problem hiding this comment.
Removed these mentions in #15661
| @@ -196,6 +197,9 @@ public void run(Operation op) { | |||
|
|
|||
| ensureNoPartitionProblems(op); | |||
|
|
|||
| if (op instanceof IsLockedOperation) { | |||
This was referenced Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old LockService is moved to internal
locksupportpackage.It's still provides locking support to
IMapandMultiMap.Client protocol PR: hazelcast/hazelcast-client-protocol#233
EE: https://github.com/hazelcast/hazelcast-enterprise/pull/3186