Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds nullability checks and annotations to remaining services #15842

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Oct 23, 2019

Adds Nonnull and Nullable annotations to CP subsystem, logging service,
lifecycle service, partition service and client service.
Aligned behaviour of client-side XAResourceProxy with the member-side
implementation when it comes to behaviour with null parameters.
Added FunctionalInterface to LogListener and cleaned up some JDK8
code.

I realise there's much more API that might be covered (including return values) but this is as far as I'm willing to go at the moment.

EE: hazelcast/hazelcast-enterprise#3268

@mmedenjak mmedenjak added this to the 4.0 milestone Oct 23, 2019
@mmedenjak mmedenjak requested a review from hazelcast/clients as a code owner Oct 23, 2019
@mmedenjak mmedenjak self-assigned this Oct 23, 2019
Adds Nonnull and Nullable annotations to CP subsystem, logging service,
lifecycle service, partition service and client service.
Aligned behaviour of client-side XAResourceProxy with the member-side
implementation when it comes to behaviour with null parameters.
Added FunctionalInterface to LogListener and cleaned up some JDK8
code.
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-nullability branch from 0fc60fe to a2b0e6e Oct 23, 2019
@sancar
sancar approved these changes Oct 23, 2019
@mmedenjak mmedenjak merged commit aa9ac70 into hazelcast:master Oct 23, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-nullability branch Oct 23, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Oct 23, 2019

Thank you for the reviews @sancar @metanet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.