Adds nullability checks and annotations to remaining services #15842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Nonnull and Nullable annotations to CP subsystem, logging service, lifecycle service, partition service and client service. Aligned behaviour of client-side XAResourceProxy with the member-side implementation when it comes to behaviour with null parameters. Added FunctionalInterface to LogListener and cleaned up some JDK8 code.
mmedenjak
force-pushed
the
4.0-nullability
branch
from
0fc60fe
to
a2b0e6e
Compare
sancar
approved these changes
Oct 23, 2019
metanet
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Nonnull and Nullable annotations to CP subsystem, logging service,
lifecycle service, partition service and client service.
Aligned behaviour of client-side XAResourceProxy with the member-side
implementation when it comes to behaviour with null parameters.
Added FunctionalInterface to LogListener and cleaned up some JDK8
code.
I realise there's much more API that might be covered (including return values) but this is as far as I'm willing to go at the moment.
EE: https://github.com/hazelcast/hazelcast-enterprise/pull/3268