Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch exception when method can't be make accessible #15892

Merged
merged 1 commit into from Oct 31, 2019
Merged

catch exception when method can't be make accessible #15892

merged 1 commit into from Oct 31, 2019

Conversation

alex-dukhno
Copy link
Contributor

This PR is the fix for #15884

Catching Exception however it throws InaccessibleObjectException

@blazember could you please take a look?

@devOpsHazelcast
Copy link
Collaborator

Can one of the admins verify this patch?

@mmedenjak mmedenjak added this to the 4.0 milestone Oct 30, 2019
@blazember
Copy link
Contributor

run-lab-run

@blazember blazember self-requested a review October 31, 2019 08:36
@blazember
Copy link
Contributor

Approving it with the note that we log at Hazelcast startup at WARN level if the necessary --add-opens, --add-modules and --add-exports are missing in a modularized runtime, so the user gets a notification right after starting the instance. Going to merge it after getting a successful build in the CI.

@alex-dukhno thank you for the fix 💯

@blazember blazember mentioned this pull request Oct 31, 2019
Merged
@blazember blazember merged commit 2d105a7 into hazelcast:master Oct 31, 2019
@alex-dukhno alex-dukhno deleted the Metric-memory.freePhysical-throws-InvocationTargetException-on-JDK11 branch October 31, 2019 15:39
@blazember blazember mentioned this pull request Oct 31, 2019
Closed
@mmedenjak mmedenjak added the Source: Community PR or issue was opened by a community user label Apr 13, 2020
@alex-dukhno alex-dukhno mentioned this pull request Dec 17, 2020
Merged
@mmedenjak mmedenjak added Source: Internal PR or issue was opened by an employee Team: Management Center Source: Community PR or issue was opened by a community user and removed Source: Community PR or issue was opened by a community user Source: Internal PR or issue was opened by an employee labels Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazember blazember blazember approved these changes

@mmedenjak mmedenjak mmedenjak approved these changes

Assignees
No one assigned
Labels
Module: Metrics Source: Community PR or issue was opened by a community user Team: Core Team: Management Center Type: Defect
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-dukhno @devOpsHazelcast @blazember @mmedenjak