Fixes handling of cache statistics #15937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used Config.findCacheConfig can only lookup cache configs added statically or dynamically via Config.addCacheConfig but misses configuration of dynamically created caches via CacheManager.createCache, so it is wrong to use it to filter stats. Instead, we retrieve cache configs from CacheService.getCacheConfigs which includes configuration of all known caches at runtime.
vbekiaris
force-pushed
the
fixes/4.0/cache-stats-mc
branch
from
e2719b9
to
2724b90
Compare
blazember
reviewed
Nov 5, 2019
| Map<String, LocalCacheStats> stats = cacheService.getStats(); | ||
| for (String cacheNameWithPrefix : stats.keySet()) { | ||
| assertContains(cacheNameWithPrefix, CACHE_WITH_STATS_PREFIX); | ||
| } |
There was a problem hiding this comment.
Don't we need an assertEquals(100,stats.size()) too? It's verified by the next case though that the stat disabled caches actually don't have stats. Do we need then the 50 stats disabled caches in this test?
There was a problem hiding this comment.
I pushed a commit removing the redundant test.
emre-aydin
approved these changes
Nov 6, 2019
blazember
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used
Config.findCacheConfigcan only lookupcache configs added statically or dynamically via
Config.addCacheConfigbut misses configuration of dynamically created caches via
CacheManager.createCache, so it is wrong to use it to filter stats.Instead, we retrieve cache configs from
CacheService.getCacheConfigswhich includes configuration of all caches known at runtime.
Fixes missing cache statistics from MC