Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiplier config to be set as double from xml #15990

Merged
merged 1 commit into from Nov 13, 2019
Merged

Fix multiplier config to be set as double from xml #15990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion hazelcast-client/src/main/java/com/hazelcast/client/config/ClientDomConfigProcessor.java
View file
Open in desktop
Expand Up @@ -191,7 +191,7 @@ private void handleConnectionRetry(Node node, ClientConnectionStrategyConfig str
} else if (maxBackoffMillis.equals(nodeName)) {
connectionRetryConfig.setMaxBackoffMillis(getIntegerValue(maxBackoffMillis, value));
} else if (multiplier.equals(nodeName)) {
connectionRetryConfig.setMultiplier(getIntegerValue(multiplier, value));
connectionRetryConfig.setMultiplier(getDoubleValue(multiplier, value));
} else if ("fail-on-max-backoff".equals(nodeName)) {
connectionRetryConfig.setFailOnMaxBackoff(getBooleanValue(value));
} else if (jitter.equals(nodeName)) {
Expand Down
2 changes: 1 addition & 1 deletion ...ast-client/src/test/java/com/hazelcast/client/config/AbstractClientConfigBuilderTest.java
View file
Open in desktop
Expand Up @@ -280,7 +280,7 @@ public void testExponentialConnectionRetryConfig() {
assertEquals(0.5, exponentialRetryConfig.getJitter(), 0);
assertEquals(2000, exponentialRetryConfig.getInitialBackoffMillis());
assertEquals(60000, exponentialRetryConfig.getMaxBackoffMillis());
assertEquals(3, exponentialRetryConfig.getMultiplier(), 0);
assertEquals(3.1, exponentialRetryConfig.getMultiplier(), 0);
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion hazelcast-client/src/test/resources/hazelcast-client-full.xml
View file
Open in desktop
Expand Up @@ -285,7 +285,7 @@
<connection-retry enabled="true">
<initial-backoff-millis>2000</initial-backoff-millis>
<max-backoff-millis>60000</max-backoff-millis>
<multiplier>3</multiplier>
<multiplier>3.1</multiplier>
<fail-on-max-backoff>true</fail-on-max-backoff>
<jitter>0.5</jitter>
</connection-retry>
Expand Down
2 changes: 1 addition & 1 deletion hazelcast-client/src/test/resources/hazelcast-client-full.yaml
View file
Open in desktop
Expand Up @@ -274,7 +274,7 @@ hazelcast-client:
enabled: true
initial-backoff-millis: 2000
max-backoff-millis: 60000
multiplier: 3
multiplier: 3.1
fail-on-max-backoff: true
jitter: 0.5

Expand Down