Handle closed client connection after registration #16407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could happen that this connection is already closed and onConnectionClose() is called even before the authentication handling logic is executed. In this case, now we have a closed but registered connection in the client connection manager. We do a final check to remove this connection if needed. This check was already here before and removed with 3d897c2 because of wrong reasoning. Fixes hazelcast#16288
sancar
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could happen that this connection is already closed and onConnectionClose()
is called even before the authentication handling logic is executed. In this
case, now we have a closed but registered connection in the client connection
manager. We do a final check to remove this connection if needed.
This check was already here before and removed with 3d897c2 because of wrong
reasoning.
Fixes #16288