Improve client partition table update push mechanism #16939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2020
sancar
approved these changes
Apr 29, 2020
mdogan
force-pushed
the
client-ptable-update-4.1
branch
from
73d97ed
to
0a829fb
Compare
When a partition table update is detected, a member pushes updated partition table to its clients. When there are many clients (hundreds or more), partition table updates cause big latencies in migration system. Reason is, partition service's lock must be acquired to create partition table's latest view and this is called on every partition update. To fix that, we can skip some intermediate partition table updates. There's no need to push every update, because once partition table updates begin, generally there'll be many. Most of them will be stale in a short time. It's fine to skip some to reduce push frequency and lock contention.
mdogan
force-pushed
the
client-ptable-update-4.1
branch
from
0a829fb
to
d174012
Compare
andrewoelfing
pushed a commit
to andrewoelfing/hazelcast
that referenced
this pull request
May 11, 2020
When a partition table update is detected, a member pushes updated partition table to its clients. When there are many clients (hundreds or more), partition table updates cause big latencies in migration system. Reason is, partition service's lock must be acquired to create partition table's latest view and this is called on every partition update. To fix that, we can skip some intermediate partition table updates. There's no need to push every update, because once partition table updates begin, generally there'll be many. Most of them will be stale in a short time. It's fine to skip some to reduce push frequency and lock contention.
webashutosh
pushed a commit
to webashutosh/hazelcast
that referenced
this pull request
Jun 29, 2020
When a partition table update is detected, a member pushes updated partition table to its clients. When there are many clients (hundreds or more), partition table updates cause big latencies in migration system. Reason is, partition service's lock must be acquired to create partition table's latest view and this is called on every partition update. To fix that, we can skip some intermediate partition table updates. There's no need to push every update, because once partition table updates begin, generally there'll be many. Most of them will be stale in a short time. It's fine to skip some to reduce push frequency and lock contention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a partition table update is detected, a member pushes
updated partition table to its clients.
When there are many clients (hundreds or more), partition table updates
cause big latencies in migration system. Reason is, partition service's lock must be acquired
to create partition table's latest view and this is called on every partition update.
To fix that, we can skip some intermediate partition table updates. There's no need to push every update,
because once partition table updates begin, generally there'll be many. Most of them will be stale
in a short time. It's fine to skip some to reduce push frequency and lock contention.
3.12: #16937
4.0: #16938