Allow operations while node is shutting down #17028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we are rejecting all operations, except the ones marked as `AllowedDuringPassiveState`, while node is shutting down (`nodeState == PASSIVE`). But this constraint does not provide any additional safety guarantees. There are four major tasks are executed during node shutdown: - Partition replicas owned by shutting down member are migrated to other members. - Latest un-replicated CRDT state is replicated to other members. - If the member is CP and persistence is not enabled, it removes itself from CP groups. - CP sessions are closed. All of these have their own mechanisms to provide safety. With this change, we will allow submitting & executing operations while a node is shutting down. This is especially important when node holds large data (hundreds of GBs). Because graceful shutdown process more than a few minutes. And rejecting/blocking operations on & from that node during that period reduces availability of the cluster.
ahmetmircik
approved these changes
Jun 4, 2020
petrpleshachkov
approved these changes
Jun 4, 2020
asimarslan
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are rejecting all operations, except the ones marked as
AllowedDuringPassiveState, while node is shutting down (nodeState == PASSIVE).But this constraint does not provide any additional safety guarantees.
There are four major tasks are executed during node shutdown:
All of these have their own mechanisms to provide safety.
With this change, we will allow submitting & executing operations
while a node is shutting down. This is especially important when node holds
large data (hundreds of GBs). Because graceful shutdown process more than
a few minutes, rejecting/blocking operations on & from that node
during that period reduces availability of the cluster.
Fixes #16932